(!) Use of eval is strongly discouraged, rollup

dougwilson / nodejs-depd

Deprecate all the things

MIT License

325 stars 87 forks source link

(!) Use of eval is strongly discouraged, rollup #38

Closed dasharup closed 4 years ago

dasharup commented 4 years ago

is eval really needed?

(!) Use of eval is strongly discouraged
https://rollupjs.org/guide/en/#avoiding-eval
node_modules/depd/index.js
413: 
414:    // eslint-disable-next-line no-eval
415:   var deprecatedfn = eval('(function (' + args + ') {\n' +
                          ^
416:     '"use strict"\n' +
417:     'log.call(deprecate, message, site)\n' +
created deploy/bundle.js in 2.8s

dougwilson commented 4 years ago

Yes, this module used to use eval, but eval was removed from version 2.0, released over a year ago.