Removing : from client_id, breaks in kafka 0.9

doujiang24 / lua-resty-kafka

Lua kafka client driver for the Openresty based on the cosocket API

BSD 3-Clause "New" or "Revised" License

802 stars 275 forks source link

Removing : from client_id, breaks in kafka 0.9 #15

Closed afsheenb closed 8 years ago

afsheenb commented 8 years ago

Hello,

As detailed in this thread:

https://groups.google.com/forum/#!topic/confluent-platform/WhMhORdTDz0

the lua-resty-kafka library sets a client_id that includes a character considered invalid when used for autocreation of JMX metrics. I've edited this manually so that we can interoperate with kafka 0.9.

doujiang24 commented 8 years ago

@afsheenb Thanks for the patch. Just merged.