Closed laoshancun closed 4 years ago
@laoshancun ,ssl problem solved yet?
Not yet, but I changed my plan.
@doujiang24 Is there any plan to add this feature?
@doujiang24 Is there any plan to add this feature?
no plan from my side yet, patches welcome :)
@doujiang24 we would love to have support for ssl or sasl. I see that there was an effort to add support for sasl_plain but it was closed. Do you remember why it was closed? What's left to complete that patch? Any potential challenges that you foresee?
@murillopaula it's closed by the original author, PR welcome :) and we have enabled the Travis ci now, please remember to add related test cases for it :)
+1, would love to see TLS connection support in this plugin with Kafka. I need it for a logging effort. If I set the LUA_SSL_TRUSTED_CERTIFICATE
https://github.com/openresty/lua-nginx-module#lua_ssl_trusted_certificate , is there a way @doujiang24 to write the tcp socket connections to use the openresty way? I am thinking maybe we swap out some broker logic here:
https://github.com/doujiang24/lua-resty-kafka/blob/master/lib/resty/kafka/broker.lua#L25
to support: https://github.com/openresty/lua-nginx-module#tcpsocksslhandshake
Would that be an acceptable PR? I think I can do it based on how some other projects in the open source space that leverage openresty manage tcp connections.
-Jeremy
@jeremyjpj0916 yeah, you are right, PR welcome, thanks :)
Technically this issue can be closed. This lib. Now supports ssl connections.
@jeremyjpj0916 Thanks, closing it.
is there any plan to support ssl?