Closed OWissett closed 1 year ago
Looks good to me (also see reaction on the issue itself). One small refactor though, maybe it would be better to rename prepare_identifier
-> prepare_identifier_uppercase
, and prepare_identifier_case_sensitive
-> prepare_identifier
. I think that captures the gist of it a bit better. But feel free to disagree.
Sounds fine to me. I will fix those in a bit
This functionality could be linked with the builder solution I suggest in #113
Addressed naming suggestoins
109
Problem: Some PDB files contain two occurrences of the same chain ID, e.g., B and b. The library automatically capitalizes change IDs, this leads to a chain ID conflict which is not possible to resolve simply.
Solution: Remove the functionality which automatically capitalizes the values.
Notes: