Closed douweschulte closed 2 years ago
Thanks! I'll wait for the tests to run and then merge.
Fine with me. It was nice to see how the code evolved during the past days and different PRs. And I do think we have a very nice solution with a huge performance potential.
Fine with me. It was nice to see how the code evolved during the past days and different PRs. And I do think we have a very nice solution with a huge performance potential.
Agreed. I'm still wondering how to get parsing of that 1HTQ monster to acceptable timings but... eh. Also, it won't parse properly anyway because the validation throws an error :D
@DocKDE Here I refactored the PDB parsing to use
HashMap
s internally which are turned into the appropriate collection after parsing. The major problem is thatHashMap
s do not retain ordering so I had to addPDB::full_sort
in the parsing routine to keep all tests running. Potentially this could be solved by usingIndexMap
. I am very interested in your view on this approach.