search

dovecot / imaptest

IMAP server tester
Other
51 stars 21 forks source link

Current NOTIFY tests are invalid #18

Closed ksmurchison closed 1 year ago

ksmurchison commented 1 year ago

The current NOTIFY tests (src/tests/notify) use the MessageNew, MessageExpunge, and FlagChange events independently, which is invalid per RFC 5465, Section 5:

   If the FlagChange and/or AnnotationChange events are specified,
   MessageNew and MessageExpunge MUST also be specified by the client.
   Otherwise, the server MUST respond with the tagged BAD response.

   If one of MessageNew or MessageExpunge is specified, then both events
   MUST be specified.  Otherwise, the server MUST respond with the
   tagged BAD response.
sirainen commented 1 year ago

Somehow I had thought it applied only to selected mailbox, but looks like not. I'll get that fixed.

ksmurchison commented 1 year ago

I initially though they same thing until I read the notes in the ABNF, and then went back and read the prose.

sirainen commented 1 year ago

Fixed