search

dovecot / imaptest

IMAP server tester
Other
51 stars 21 forks source link

Add PORT to settings.h #27

Closed emersion closed 7 months ago

cmouse commented 7 months ago

Hi!

Thank you for your pull request, can you explain why this is needed?

emersion commented 7 months ago

The docs say:

You may want to modify the default configuration from #defines in src/settings.h.

This isn't required, but if you run imaptest often, this way you don't have to give the same parameters every time.

I run imaptest often, and my server is running on port 1143 (unprivileged port to be able to bind without root privileges).

cmouse commented 7 months ago

I wonder if it would make sense to default to 143 instead?

emersion commented 7 months ago

conf.port defaults to 0 so that's why I picked this value. 143 wouldn't be appropriate for POP: https://github.com/dovecot/imaptest/blob/1425ad0caaf727418136cde776241e4cbcf59b81/src/pop3-client.c#L424

cmouse commented 7 months ago

ok