search

dovecot / imaptest

IMAP server tester
Other
51 stars 21 forks source link

Bad ESEARCH test mails #35

Closed shikharid closed 2 months ago

shikharid commented 4 months ago

https://github.com/dovecot/imaptest/blob/main/src/tests/esearch.mbox

These emails have no headers, not even a date header.

Any particular reason?

RFC 5322 clearly states that:

The only required header fields are the origination date field and the originator address field(s). All other header fields are syntactically optional.

So these emails should atleast have date and from headers

It's a small fix, I already have a fork with these use proper emails similar to other tests. Let me know and I will raise a PR

sirainen commented 4 months ago

Pull request would be helpful, thanks. I just did it this way because Dovecot doesn't care about missing headers and they weren't relevant for the test.

shikharid commented 4 months ago

Thanks for the quick reply @sirainen ! Here you go: https://github.com/dovecot/imaptest/pull/36

shikharid commented 3 months ago

Hey @sirainen, these changes are still not available in main

sirainen commented 3 months ago

Oh, the git repo syncing has broken again because of some changes merged directly to github. I think need to wait for @cmouse to fix it after he comes back from vacation.

cmouse commented 2 months ago

Merged as b96f818d9b62ad016d79dae999ff69544e797ca3