search

dovecot / imaptest

IMAP server tester
Other
51 stars 21 forks source link

tests: fix bad email msgs in esearch.mbox #36

Closed shikharid closed 3 months ago

shikharid commented 4 months ago

Issue https://github.com/dovecot/imaptest/issues/35

shikharid commented 4 months ago

Off topic, help me out if you can @sirainen :

Are the tests bundled into the binary? If so, how can I provide them as an arg or lead to binary to use the bundled tests.

slusarz commented 4 months ago

Off topic, help me out if you can @sirainen :

* I have a job that uses the [static binary here](https://github.com/dovecot/imaptest/releases/tag/latest) to run these imaptests rather than build from scratch

* But I still need to checkout the repo to bring in the tests and provide it as an argument (`./imaptest ... test=tests/`)

Are the tests bundled into the binary? If so, how can I provide them as an arg or lead to binary to use the bundled tests.

Tests are defined in individual text files. The binary is just that - a binary that interprets test files. So they are two distinct items.

I don't see any benefit of creating another package with binary + test files since you can do the same thing with downloading the binary and doing a git checkout of the repository to get the test files. That is easily scripted.

The intention for imaptest binary is to run on locally defined test files or for doing performance testing.

shikharid commented 4 months ago

Off topic, help me out if you can @sirainen :

* I have a job that uses the [static binary here](https://github.com/dovecot/imaptest/releases/tag/latest) to run these imaptests rather than build from scratch

* But I still need to checkout the repo to bring in the tests and provide it as an argument (`./imaptest ... test=tests/`)

Are the tests bundled into the binary? If so, how can I provide them as an arg or lead to binary to use the bundled tests.

Tests are defined in individual text files. The binary is just that - a binary that interprets test files. So they are two distinct items.

I don't see any benefit of creating another package with binary + test files since you can do the same thing with downloading the binary and doing a git checkout of the repository to get the test files. That is easily scripted.

The intention for imaptest binary is to run on locally defined test files or for doing performance testing.

Yup, as I mentioned that is what I have been doing. A binary bundled with tests would have just made the runs slightly faster for me, not that it matters much. And made atleast some sense since these tests are relatively very stable and rarely need to change.

shikharid commented 3 months ago

Can you merge these changes @sirainen ?

sirainen commented 3 months ago

Merged. Should sync into github soon.