dovrosenberg / foundry-simple-weather

Apache License 2.0
9 stars 5 forks source link

[BUG] Unable to reopen the simple weather gadget after closing it #41

Closed Dyrnwyrm closed 10 months ago

Dyrnwyrm commented 10 months ago

Describe the bug As the title says by mistake i closed the SW menu on the canvas and now i cant open it on my world, i tried to use different keybinds but nothing worked, no console errors or something like that.

To Reproduce Steps to reproduce the behavior:

  1. Close the SW menu on the canvas
  2. Try to open it using a keybind
  3. Nothing Happens
  4. Disabling and enabling the module does not fix the issue

Foundry Version: 11.315 DnD5e version: 2.3.1 Simple Weather Module Version: 1.7.0

image

dovrosenberg commented 10 months ago

Running in a browser or foundry desktop? What keybind(s) did you try? Did you try refreshing (F5)?

Also - logging in as GM or player? And can you send a screenshot of your simple weather settings... like this: image

Dyrnwyrm commented 10 months ago

Logging as GM foundry desktop i tried refreshing and nothing

i tried using ctrl+1 or the - key and nothing

dovrosenberg commented 10 months ago

Could you try this:

Dyrnwyrm commented 10 months ago

image

Here, dont know about the last error while using that command on the console.

dovrosenberg commented 10 months ago

Oops... that should have been windowPosition not windowLocation. But I've added a new release (1.7.1) with some debugging code in it. Could you try updating to 1.7.1 then in the console do game.modules.get('simple-weather').api.debugOutput() and copy and paste the output back here?

Also, could you send me a list of active modules? I can't reproduce this, but you're at least the 2nd person with a similar issue. I'm wondering if it's some inter-module issue.

Dyrnwyrm commented 10 months ago

Here is the debug from console:

image

Got this error today after the update:

image

And here is the modules i use, sorry for taking so long to answer

Active Modules

Action Pack v11.2 Bugs URL Active-Auras v0.8.3 Bugs URL Active Token Effects v0.7.0 Bugs URL Anonymous v1.4.4 Bugs URL Arms Reach v2.3.4 Bugs URL Build-a-Bonus v11.4.2 Carousel Combat Tracker v2.5.4 Chat Portrait v0.9.4 Bugs URL Combat Booster: Turn Marker, Recent Actions and more v3.6.1 DDB-Importer: A D&D Beyond Integrator v3.5.9 DFreds Convenient Effects v6.0.0 Bugs URL DFreds Droppables v3.0.1 Bugs URL DFreds Effects Panel v3.1.0 Bugs URL Dice So Nice! v4.6.8 Bugs URL DND5E Scriplets - 5E QOL bits and pieces v0.20 Dynamic effects using Active Effects (DAE) v11.0.23 Bugs URL Midi QOL v11.1.11 Bugs URL Chris's Premades v0.8.25 Effect Macro v11.0.3 Foundry Redirect: Better invitation links v2.0.4 FXMaster v4.0.2 Bugs URL Grid Scaler v1.4.4 Health Estimate v31.7.9 Bugs URL Hourglass v1.7.0 Illandril's Inventory Sorter (5e) v2.3.0 Bugs URL Item Collection\Item Container for Dnd5e v11.0.3 Item Piles v2.8.1 Bugs URL Items with Spells DnD5e v11.0.5 Bugs URL JB2A - Patreon Complete Collection v0.6.2 Kris's Compendium of Trade Goods v0.13 lib - Color Settings v2.9.1 🏷️ Item Tags (Library) v1.1.0 Bugs URL libWrapper v1.12.13.0 Bugs URL socketlib v1.0.13 Bugs URL Limits v1.0.2 Bugs URL Universal Battlemap Importer v3.0.0 Mass Edit v1.44.8 Material Components v11.1.3 Bugs URL Module Management+ v2.2.3 Bugs URL Monk's Bloodsplats v11.07 Bugs URL Monk's Combat Details v11.08 Bugs URL Monk's Combat Marker v11.03 Bugs URL Monk's Enhanced Journal v11.07 Bugs URL Monk's Player Settings v11.04 Bugs URL Monk's TokenBar v11.05 Bugs URL Monk's Wall Enhancement v11.02 Bugs URL Perceptive v2.8.3 Polyglot v2.3.14 Rarity Colors v0.3.7 Bugs URL Rest Recovery for 5E v1.4.17 Reverse Initiative Order v1.2.1 Bugs URL Revised Weapons & Equipment v11.0.0 Rideable v2.15.10 Bugs URL routinglib v1.1.0 Bugs URL Sequencer v3.1.4 Bugs URL Automated Animations v4.2.68 D&D5e Animations v1.6.0 ✨ Automated Objects, Interactions and Effects 🔥 v1.1.4.1 Bugs URL Show Token Art v1.0.3 Shuggaloaf's Simple NPC Generator vv4.0.11 Simple Calendar v2.4.3 Bugs URL Simple Weather v1.7.1 Bugs URL SmallTime v1.19.1 Bugs URL Smart Target v1.0.1 Bugs URL Stairways (Teleporter) v0.10.2 Bugs URL Tagger v1.4.5 Bugs URL Template Macro v11.0.1 Tidy5e Sheet v0.9.18 Bugs URL Times Up v11.0.3 Bugs URL Token Attacher vv4.5.13 Token Auras v2.7 Token Magic FX v0.6.5.0 Token Mold v2.20.3 Bugs URL Token Variant Art v4.59.0 Bugs URL Token Warp v11.0.1.1 Bugs URL Variant Encumbrance+Midi vv0.13.5 Bugs URL Vision 5e v1.10.4 Bugs URL Walled Templates v0.6.10 Wall Height v5.0.3 Warp Gate v1.19.0 Arbron’s Summoning v1.1.4 Bugs URL

dovrosenberg commented 10 months ago

In the console, can you try:

game.settings.set('simple-weather', 'windowPosition', {left:0, bottom:0}) and then wait a second or two and then refresh (F5). If it works, you'll see the box appear in the bottom left corner

Dyrnwyrm commented 10 months ago

No box after doing that console command, by the way i got this error now after the update, maybe its related to the issue?

image

dovrosenberg commented 10 months ago

Can you show me your configuration settings box like the picture I posted at the top? Also, above the getData debug stuff you posted, did it show a value for currentlyHidden?

dovrosenberg commented 10 months ago

I think upgrading to 1.7.2 will fix that console error, so we can see if it's related.

Dyrnwyrm commented 10 months ago

Upgrading to 1.7.2 fixes the issue of the invisible window and the console error, also it fixes the keybinds

SesuUisu commented 10 months ago

I had the same issue, but after upgrading to 1.7.2, I had to start once without anyother module than Simple Weather. Otherwise it still didn't shown (just for record if someone else has the same problem).

dovrosenberg commented 10 months ago

is the console error still there?

Dyrnwyrm commented 10 months ago

Nope, both issues are fixed thanks for the quick fix

dovrosenberg commented 10 months ago

Cool... let me know if it comes back. Can you clarify what fixed it? You loaded the world with no other modules? Then it showed up and you added all the other modules back?

Dyrnwyrm commented 10 months ago

Just updated the module and opened the world after that, no extra steps

SesuUisu commented 10 months ago

Cool... let me know if it comes back. Can you clarify what fixed it? You loaded the world with no other modules? Then it showed up and you added all the other modules back?

I had to load the World without any extea module. After that i had the SW back and could load the other modules without issue.