dovy / elusive-icons

http://elusiveicons.com
100 stars 27 forks source link

Use git tags #10

Open Jerska opened 9 years ago

Jerska commented 9 years ago

Hi, thanks for these great icons! You pushed a bower.json in your repo. However, you specified the version number in it, when bower actually uses git tags.

$ bower info elusive-icons
bower elusive-icons#*       not-cached git://github.com/reduxframework/Elusive-Icons.git#*
bower elusive-icons#*          resolve git://github.com/reduxframework/Elusive-Icons.git#*
bower elusive-icons#*         checkout master
bower elusive-icons#*         resolved git://github.com/reduxframework/Elusive-Icons.git#5ddd9167c8

{
  name: 'elusive-icons',
  description: 'Elusive Icons',
  keywords: [],
  homepage: 'http://elusiveicons.com',
  // ...
}

No versions available.

Could you tag your last commit v2.0.0 ? Thanks in advance!

Jerska commented 9 years ago

This would allow to submit this repo to https://github.com/jsdelivr/jsdelivr , with auto updates on each git tag (see https://github.com/jsdelivr/libgrabber#add-updatejson-schema ). If I'm bringing this up, it's because the <link rel="stylesheet" href="//maxcdn.bootstrapcdn.com/elusive-icons/2.0.0/css/elusive-icons.min.css"> doesn't work and I would love to have a CDN'ed version.

dovy commented 9 years ago

We're working on a new version and I'll incorporate this when we release. Trying to work out a FEW more bugs. ;)

Jerska commented 9 years ago

Thanks for the answer! Wouldn't it be possible to fix these in 2.0.1 ? :wink:

dovy commented 9 years ago

Hah, it will be version 2.0. I just need to do it. I'll make it happen next week. Along with our new domain and all. ;)

Jerska commented 9 years ago

Alright, nice!