search

dowjones / gulp-bundle-assets

Create static asset (js, css) bundles from a config file: a common interface to combining, minifying, revisioning and more
MIT License
133 stars 36 forks source link

Possible to add async/defer to result script tags? #97

Closed AndrewCraswell closed 7 years ago

AndrewCraswell commented 7 years ago

I searched through the documentation but didn't see any mention of how to configure certain bundles to add async or defer attributes to the script elements. Is this already possible, or is this a feature request you'd consider approving a PR for?

chmontgomery commented 7 years ago

Yes, this is definitely possible. Unfortunately the documentation is a little hidden. See examples/custom-result https://github.com/dowjones/gulp-bundle-assets/tree/master/examples/custom-result#custom-results

I would accept PRs to update the docs to make this more discoverable. A wiki page would also do the trick.

Thanks. Chris

On Fri, Jul 14, 2017 at 10:22 PM, Andrew Craswell notifications@github.com wrote:

I searched through the documentation but didn't see any mention of how to configure certain bundles to add async or defer attributes to the script elements. Is this already possible, or is this a feature request you'd consider approving a PR for?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dowjones/gulp-bundle-assets/issues/97, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOLpOaDGTqR8jwv8kXqTmHcZCJB7vqQks5sODBvgaJpZM4OY5r4 .

chmontgomery commented 7 years ago

if you have more questions let me know