dowlinglab / HFC-IL-thermodynamic-model-selection

MIT License
1 stars 0 forks source link

FIM Scaling #18

Closed bbefort closed 1 year ago

bbefort commented 1 year ago

11/22 To Do: (@bbefort, @jialuw96, @adowling2 )

bbefort commented 1 year ago

Note Nov 22, 2022.pdf

bbefort commented 1 year ago

@jialuw96 @adowling2 Here are the sigma^2 values across systems for the same model:

R32/emim (PR-6): 6.129898371002546e-09 (PR-4): 8.37460197746672e-09

R32/bmim (PR-6): 9.278203566112187e-08 (PR-4): 1.5644966239299104e-07

R125/emim (PR-6): 1.4171234680259503e-07 (PR-4): 1.2511693644269783e-07

See here for details of the calculation: https://github.com/dowlinglab/extractive-distillation2/blob/mbdoe/modsel/paramest/emimtf2n/R32/Final_Results/Data/Fits/Uncertainty-residuals-calc.ipynb

These seem small and vary by orders of magnitude between systems. What do you think?

bbefort commented 1 year ago

Also, KU uses +/- 0.0008 MPa uncertainty in the pressure value.

adowling2 commented 1 year ago

@bbefort What is the square root of the variance of the residuals converted to MPa? Is this standard deviation consistent with the +/- value from KU?

bbefort commented 1 year ago

@adowling2 Sorry, I forgot to do this. The square roots in MPa (approximately) for the example systems above:

R32/emim (PR-6): 0.00008 (PR-4): 0.00009

R32/bmim (PR-6): 0.0003 (PR-4): 0.0004

R125/emim (PR-6): 0.0004 (PR-4): 0.0004

So they are generally on the same order of magnitude as the KU values. I propose we use the KU value as it is easily defensible. We can comment that we calculated the residuals using the method I used above and they were comparable. Let me know what you think. Thanks.

adowling2 commented 1 year ago

Let's go with the KU value of +/- 0.0008 MPa (standard deviation, sigma) as @bbefort suggests. Moreover, let's report the values posted here in an SI table for completeness.

adowling2 commented 1 year ago

@jialuw96 Post here when you have an update or if you have any questions.

jialuw96 commented 1 year ago

Please see the following for the heatmaps for R32/emim system, PR_quad model.

Q: do we want to scale with parameter values? Results before, we generated all results (Prior info, heatmaps) with scale_parameter=True. Currently, I only updated this option for PR_quad model.

image

image

image

image

adowling2 commented 1 year ago

@jialuw96 Thank you for your update.

I am a little confused. Are you scaling the results or the parameters? The text of our post suggests you are scaling the results (the numerator of the sensitivities Q) by the syntax suggests you are scaling the unknown parameters (denominator of the sensitivities Q). What is the difference between scale_constant, scale_unit, and scale_parameter?

I looked at the interface for Pyomo.DoE (https://github.com/jialuw96/pyomo/blob/e3a2976e10cbccb7d720e748fe8b1c6e311cfb95/pyomo/contrib/doe/fim_doe.py#L366) which did not clarify my question.

jialuw96 commented 1 year ago

@adowling2 scale_parameter scales Q by the parameters (denominator of Q), scale_unit == scale_constant scales Q by the measurement unit (numerator of Q). The settings are as the following (I change scale_unit to be scale_constant here to avoid confusion, they are the same option):

With scale_constant changing from E-5 to E-6, we are changing the measurement unit from bar to MPa. I am wondering if we keep scaling Q with parameters, or not, or either is ok as along as we keep this option consistent? Thank you!

jialuw96 commented 1 year ago
jialuw96 commented 1 year ago

Change the unit to Pascal, reproduce the heatmap above: (scale_parameter = False, scale_unit = 1, STD = 90 Pascal)

image

image

image

They are consistent with the results when we use the unit MPa.

Try setting: scale_parameter = True (scale_parameter = True, scale_unit = 10**(-6), STD = 0.00009 MPa)

image

image

image

bbefort commented 1 year ago

@adowling2 just to confirm, we want to use the plots where Jialu scales the parameters (final three in above post)?

bbefort commented 1 year ago

@jialuw96 Could you please remake these plots?

Screen Shot 2022-12-02 at 11 51 17 AM
adowling2 commented 1 year ago

@bbefort Yes, we now have consistency with data/predictions in MPa or Pa. I like using parameter scaling. We'll need to describe that in the methods (just a sentence is fine).

Let's go with black circles for the data.

jialuw96 commented 1 year ago

@adowling2 When you say "go with black circles for the data", do you mean we use black circles for the 7th, and 8th experiments too? In the above figure, the first 6 exps are black circles, the 7th is star, and the 8th is triangle. Thank you!

adowling2 commented 1 year ago

The new figures you posted earlier have grey circles

jialuw96 commented 1 year ago

@bbefort Please see the following figures:

[6 experiments prior, exp 2, 5, 12, 19, 23, 26 ] a image

b image

c image

[7 exps, add 16] d image

e image

f image

[8 exps, add 3] g image

h image

i image

bbefort commented 1 year ago

@jialuw96 The FIM values changed for this, correct? If so, where do I find the new/updated FIM?

Thanks!

jialuw96 commented 1 year ago

@bbefort Please see the updated figures, with STD= 0.00008 MPa:

[6 experiments prior, exp 2, 5, 12, 19, 23, 26 ] image

image

image

[7 exps, add 16]

image

image

image

[8 exps, add 3] image

image

image