dowlinglab / HFC-IL-thermodynamic-model-selection

MIT License
1 stars 0 forks source link

Encapsulate CEOS regression code in a class #3

Closed adowling2 closed 1 year ago

adowling2 commented 3 years ago

Motivation: Does it make sense to create a "helper" class (or classes) that allows a user to easily work with the CEOS model and the experimental data? This could simplify generating the configuration file.

adowling2 commented 3 years ago

@agarciadiego When you get a chance, please post here and tag me with the names of the code you presented earlier this week. I'll then look through it and propose a draft 1 "UML" diagram. We can then discuss; it is makes sense, we can reorganize.

adowling2 commented 3 years ago

This post just collects my current thoughts... this still needs to be refined after seeing @agarciadiego's code.

CEOSHelper - automatically configures IDAES for the user

CEOSData - We could create a class that holds the data the goes into configuration block. This class would have one or two methods - mainly read the data from a file. Or we could not do this as the configuration block is already an object.

SolubilityExperiment - holds data for each set of experiments

ParmestHelper - generalize the interface to parmest