Closed ewmson closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/downforacross/downforacrosscom/6j2x8rh6a
✅ Preview: https://downforacrosscom-git-fork-ewmson-eslint.downforacross1.now.sh
need to fix why it is not deploying
Thanks for setting this up! I'm on board with all the judgment calls you made, can always change them in the future if we need to
Adds eslint to run (with lint-staged) before every commit in the codebase (unless you specifically disable the hooks).
NOTE: look at the first 2 commits to see the non-linting changes
Starting off with airbnb style and then made some adjustments to make it not error out every single file.
Left some in as warnings that I thought we wanted to use for new files, but can be changed ex:
I made some arbitrary calls to get it all working, so am very open to changing some if we want stricter enforcement, or no warnings for the rules I mentioned earlier.
The eslintrc should be setup to work with an IDE (it does with webstorm) and can be run locally before being run on the commit hook if desired.
Errors will block the commit and warnings will not. If autofixable, then it will be done automatically.