search

downforacross / downforacross.com

Web frontend for downforacross.com -- continuation of stevenhao/crosswordsio
https://downforacrosscom.downforacross1.now.sh
MIT License
229 stars 90 forks source link

Use cross-env to make yarn start work for Windows #170

Closed JohnHKoh closed 3 years ago

JohnHKoh commented 3 years ago

The {KEY}={VALUE} syntax used to set environment variables does not work for Windows. Instead, the set keyword must be used as such: set PORT=3020. Instead of having 2 start scripts (like yarn start and yarn start-windows) to account for this difference, we can use cross-env to have a single start command without worrying about the operating system.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/downforacross/downforacross.com/4KCusSWVmzigVFtsiVvQQguTQCUd
✅ Preview: https://downforacrossc-git-fork-johnhkoh-johnhkoh-yarn-start-win-8a34bc.vercel.app

stevenhao commented 3 years ago

sounds good! i noticed cross-env is in maintenance mode, but i suppose that's not a problem for us since we're only using it in a very basic way

JohnHKoh commented 3 years ago

sounds good! i noticed cross-env is in maintenance mode, but i suppose that's not a problem for us since we're only using it in a very basic way

Yes, as per their note here the package still should be updated with necessary bug fixes or critical security updates, so hopefully it shouldn't be an issue.