search

downforacross / downforacross.com

Web frontend for downforacross.com -- continuation of stevenhao/crosswordsio
https://downforacrosscom.downforacross1.now.sh
MIT License
222 stars 92 forks source link

Adding 's' functionality in vim mode #180

Closed dangeng closed 3 years ago

dangeng commented 3 years ago

Please let me know if I'm doing this right. I have zero web dev or open source experience

Also would love to help contribute more (preferably something small and easy for a beginner), like fleshing out the vim functionality a bit more

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/downforacross/downforacross.com/9GBWpFdG8U3qbAo4VgQPccrJKQSg
✅ Preview: https://downforacrosscom-git-fork-dangeng-master-downforacross1.vercel.app

stevenhao commented 3 years ago

I personally don't use the vim mode since i'm used to arrow keys, but would certainly be interested in other vim features. maybe command mode could be cool? (press colon, type a number like 43A, press enter to jump there)

dangeng commented 3 years ago

Alright, I made the change (to be honest, I was just pattern matching :) )

Oh, I've definitely caught myself typing something like "43gg" to jump to clue 43, and being confused when nothing happens. I'll try tinkering around with adding a buffer or something for the vim commands. Then you could also add things like "dw" to delete the rest of a word. Command mode seems a bit intimidating to me tbh :)

stevenhao commented 3 years ago

Sweet, let me know if you want to chat about the design & implementation of buffer mode! there's a #contributors channel in http://downforacross.com/discord where we can discuss