downforacross / downforacross.com

Web frontend for downforacross.com -- continuation of stevenhao/crosswordsio
https://downforacrosscom.downforacross1.now.sh
MIT License
233 stars 91 forks source link

Shading/circle display error in 3/31/21 puzzle #183

Closed frozenpandaman closed 3 years ago

frozenpandaman commented 3 years ago

NYT display: Screen Shot 2021-03-31 at 18 19 09

Down for a Cross display: Screen Shot 2021-03-31 at 18 19 28

Plasser1 commented 3 years ago

This is happening in the the 4/18/21 NYT Puzzle as well https://downforacross.com/beta/play/13422 Correct circle placements: https://crosswordfiend.com/2021/04/17/sunday-april-18-2021/#ny

stevenhao commented 3 years ago

this must be a bug in the puz parser. i wonder if nyt changed something about their encoding.

frozenpandaman commented 3 years ago

@stevenhao found another likely .puz parser bug, in 4/21/2020: image image

Should be "R2D2" and "C3PO." Seems to think numbers should be Ts.

cameronfreer commented 3 years ago

See also #122

JohnHKoh commented 3 years ago

Does anyone have a .puz file they can share the demonstrates the incorrect behavior? That could help in getting to the bottom of this.

ghost commented 3 years ago

github doesn't allow me to attach .puz files in comments, but here's a file that demonstrates the circle issue when uploaded to DfA https://drive.google.com/file/d/1P_DehmxORtNi2F4rT8NbQCtE3xgIRfaw/view?usp=sharing

stevenhao commented 3 years ago

Thanks so much @JohnHKoh for the fix!

stevenhao commented 3 years ago

Turns out the bug was not in the parser, just in the frontend (did not support rectangular grids due to a bug that did a computation based on the number of rows instead of number of columns)