search

downforacross / downforacross.com

Web frontend for downforacross.com -- continuation of stevenhao/crosswordsio
https://downforacrosscom.downforacross1.now.sh
MIT License
220 stars 92 forks source link

Win Celebration on Mobile #260

Open lukevp opened 1 year ago

lukevp commented 1 year ago

We use your site/app on mobile quite a bit, and it took us some time to realize that the only indication that we've solved the puzzle on mobile is the appearance of parenthesis and pausing of solve time, plus the highlight of green on the puzzle. On desktop, it's really obvious you've won because of the confetti burst introduced in #96 , which I only discovered many weeks later.

That PR specifically didn't show confetti on mobile because of "performance issues". Is that a real concern, or was that just an assumption? I can't imagine the performance is really a big deal for a couple of seconds, if anything. Granted, I have a nice phone (iPhone 13 Pro Max) but I tried several js confetti implementations and saw no slowness on any of them. Since the animation only plays for a few seconds, I don't see this being a major issue.

Would you be open to adding confetti support to mobile? It should be straightforward to remove the mobile check from the existing PR, and I'd be happy to do so if you're open to the change.

stevenhao commented 1 year ago

no objections from me! @cleercode any thoughts?

frozenpandaman commented 1 year ago

+1

frozenpandaman commented 1 year ago

@lukevp @stevenhao Seems this issue can be closed now!

raghuvv commented 2 months ago

This might be useful if someone is looking to improve the performance of "confetti" celebration across platforms:

https://github.com/catdad/canvas-confetti