Closed pkmnnerd closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated |
---|---|---|---|---|
downforacross.com | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Jan 26, 2023 at 2:03AM (UTC) |
missed this somehow, my b. do you have any suggestions on launch plan? (e.g. ask in discord for testers, or just ship it now & wait for feedback)
do you have any suggestions on launch plan? (e.g. ask in discord for testers, or just ship it now & wait for feedback)
I think it would be fine to get some feedback before pushing, but it's impossible to make everyone happy. A survey of yes or no would make sense (as opposed to asking for changes). Just merging it and getting feedback is alright too, especially if not that many people use dark mode right now.
yeah i guess dark mode is pretty "unofficial" so let's just ship this and see what ppl think :)
thanks for your help here @pkmnnerd! i think it looks much nicer :)
Make some changes to dark mode colors following some guidelines from https://m2.material.io/design/color/dark-theme.html:
Other color changes include
Also fixed an issue with the dark mode selection changing the height of the nav bar in mobile (when it overflows).
I'm sure this doesn't cover every possible change for a proper dark mode, but it should be a decent improvement over the current dark mode. I'm happy to modify any of these changes depending on what people think about it.