Fix mobile username issue

downforacross / downforacross.com

Web frontend for downforacross.com -- continuation of stevenhao/crosswordsio

https://downforacrosscom.downforacross1.now.sh

MIT License

220 stars 92 forks source link

Fix mobile username issue #290

Closed thkim1011 closed 7 months ago

thkim1011 commented 7 months ago

This fixes the bug where mobile users don't get assigned a username until they open the chat. This happens because the usernames are initialized in the Chat component, but for mobile, the Chat component is not mounted until it is opened.

This PR fixes this issue by creating an initialUsername and updating the user's username to this value when the Game component mounts.

This fixes #272.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
downforacross.com	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 22, 2023 7:11am

sweep-ai[bot] commented 7 months ago

Apply Sweep Rules to your PR?

[ ] Apply: All new business logic should have corresponding unit tests.
[ ] Apply: Refactor large functions to be more modular.
[ ] Apply: Add docstrings to all functions and file headers.

stevenhao commented 7 months ago

Looks good! Tested on my iPhone by joining a game on safari and chrome; on chrome I entered the chat room and there were no empty names

stevenhao commented 7 months ago

this bug has been around forever. Appreciate the fix! @thkim1011

frozenpandaman commented 6 months ago

Thank you!!