search

downforacross / downforacross.com

Web frontend for downforacross.com -- continuation of stevenhao/crosswordsio
https://downforacrosscom.downforacross1.now.sh
MIT License
220 stars 92 forks source link

Select clues in Vim Mode with clue number #293

Open vasumv opened 7 months ago

vasumv commented 7 months ago

This PR adds functionality to select clues in Vim Mode using line number selection syntax (e.g. ":56" or ":56a"). Defaults direction to across.

Adds a new Vim Command mode activated by ":" that populates a command bar component. When pressing enter, the keys are parsed for a clue number and direction. Current matching is limited to just selecting clues.

Visualization of keys pressed in command mode in the bottom in a blue box. xword

Resolves #294

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
downforacross.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 8:12pm
stevenhao commented 6 months ago

sorry i think i forgot to review this. let me take a look!

stevenhao commented 6 months ago

just tested this on the vercel preview deployment. very neat!

left some inline comments about special keys like backspace & delete not working in the command buffer. good to merge after that's addressed!

vasumv commented 6 months ago

Thanks @stevenhao! Yeah, should definitely handle special keys. I'm currently out of town but will make an update in a week or so.

vasumv commented 6 months ago

@thkim1011 and I have refactored the PR a bit to add a new component for the Vim Command Bar. This should handle special keys as well. @stevenhao please take a look when you have the chance, thanks!