downforacross / downforacross.com

Web frontend for downforacross.com -- continuation of stevenhao/crosswordsio
https://downforacrosscom.downforacross1.now.sh
MIT License
220 stars 92 forks source link

Create and focus an invisible input field on click. #322

Closed flackr closed 1 month ago

flackr commented 1 month ago

This fixes #192, allowing using the non-mobile interface on devices without keyboards as having a focused input field triggers the virtual keyboard on devices that need it.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
downforacross.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 4:32am
flackr commented 1 month ago

I've ensured that the desktop version still plays fine from a computer as well as now supporting triggering touch device keyboard, playing it pretty much every day from the preview link. Can I do anything to help get this landed?

stevenhao commented 1 month ago

hey sorry for the delay for review. i don't have an ipad so i haven't been able to work on this, appreciate your help! i tried out the preview link on desktop; when clicking on a cell there seems to be some subtle flickering that doesn't happen on main site, maybe there's some :focus thing going on?

flackr commented 1 month ago

hey sorry for the delay for review. i don't have an ipad so i haven't been able to work on this, appreciate your help!

You can also test it on an iPhone if you have one by clicking the font-like icon in the url bar and telling it to load the desktop site.

i tried out the preview link on desktop; when clicking on a cell there seems to be some subtle flickering that doesn't happen on main site, maybe there's some :focus thing going on?

Thanks for catching. Yeah we were using :focus on the grid-control but focus is moved within. I've updated it to :focus-within which is well supported and fixes the issue.

flackr commented 1 month ago

@stevenhao anything more I can do to help? Here's a screenshot of me using the desktop interface with keyboard working on my iphone:

typing

Note that I've forced it to load the desktop version to show that it works. It will still load the mobile interface by default on the phone.

stevenhao commented 1 month ago

nice! looks great.