downforacross / downforacross.com

Web frontend for downforacross.com -- continuation of stevenhao/crosswordsio
https://downforacrosscom.downforacross1.now.sh
MIT License
220 stars 92 forks source link

Add autocheck button to mobile toolbar. #323

Closed flackr closed 1 month ago

flackr commented 1 month ago

This adds the autocheck button to the expanded menu on the mobile toolbar with updated styling to make its state visible above the blue menubar.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
downforacross.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 5:29pm
sweep-ai[bot] commented 1 month ago

Sweep: PR Review

src/components/Toolbar/css/index.css

Added specific color rules for .toolbar--mobile .toolbar--autocheck and its on state to ensure consistent styling within mobile toolbars.


src/components/Toolbar/index.js

Added the autocheck button to the mobile toolbar's expanded menu view.


flackr commented 1 month ago

My friends and I really like the autocheck feature. If you find the second page of the toolbar is getting too crowded we could always either add a menu or make the expand button move between two or more additional menu panes.

5hubh4m commented 1 month ago

I love auto check, so I would really appreciate it if this PR was merged into the main deployment.

However, the current implementation seems to have a bug where there’s a small chance an entered letter does not auto check and remains black. If you backspace and type it again it auto checks correctly.

flackr commented 1 month ago

However, the current implementation seems to have a bug where there’s a small chance an entered letter does not auto check and remains black. If you backspace and type it again it auto checks correctly.

This is true, however this is an issue with autocheck already (outside of this PR) and should be treated as a separate issue / pull request to fix.

5hubh4m commented 1 month ago

Yes I realised that after I looked at the commit!

stevenhao commented 1 month ago

lgtm!