search

download-directory / download-directory.github.io

Web App: Download just a sub directory from a GitHub repo.
https://download-directory.github.io
MIT License
1.25k stars 117 forks source link

Draft: add lfs support #105

Closed ascodeasice closed 10 months ago

ascodeasice commented 11 months ago

This is a draft to add LFS support as metioned in issue #42, but was stuck due to the same-origin policy of github.

I've

  1. Analyze whether the file is LFS with it's content
  2. Try to do a POST request to get the download link (failed because CORS is not allowed)
  3. Download from the link (not implemented yet)

The problem I've encountered is similar to this comment

What can I do to solve the CORS problem?

netlify[bot] commented 11 months ago

Deploy Preview for preview-for-download-directory-github-io ready!

Name Link
Latest commit c0d87d2b129379dce8290a8a2831ffc007a8ee60
Latest deploy log https://app.netlify.com/sites/preview-for-download-directory-github-io/deploys/657132b407bc270008138b83
Deploy Preview https://deploy-preview-105--preview-for-download-directory-github-io.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

fregante commented 11 months ago

What can I do to solve the CORS problem?

That's the whole issue, I think. Probably it cannot be done