search

download-directory / download-directory.github.io

Web App: Download just a sub directory from a GitHub repo.
https://download-directory.github.io
MIT License
1.25k stars 117 forks source link

Add support for Github Enterprise #29

Closed aslafy-z closed 3 years ago

aslafy-z commented 5 years ago

Fixes #28

Depends on https://github.com/fregante/list-github-dir-content/pull/16

fregante commented 5 years ago

The token also depends on the domain, as suggested in the issue

fregante commented 5 years ago

Thank you for sending these PRs 🤗

aslafy-z commented 5 years ago

I'll continue to work on this in few hours. Already added a per-instance token store. It's a pleasure, thank you for supporting such service!

aslafy-z commented 5 years ago

This part looks good to me. Can you have a look @fregante?

aslafy-z commented 5 years ago

LGTM! I'll check if it works for my GHE instance tomorrow and let you know.

fregante commented 5 years ago

Did you test with GHE?

aslafy-z commented 4 years ago

Unfortunately, now.sh is blocked in my company network. Can you drop me a copy of the released files?

fregante commented 4 years ago

Archive.zip

aslafy-z commented 4 years ago

There's one bug. Download doesn't work immediately after filling token. It needs a page refresh before starting downloading. Looks like isGHE has a incorrect value and token is null right after the first waitForToken. I need to do extended tests at home, let me know if you have an idea.

Other than that, it works perfectly!

LitoMore commented 4 years ago

Any progress?