search

download13 / ipfstube

Plays videos on IPFS
MIT License
458 stars 120 forks source link

Add support for subtitles #7

Closed llopv closed 7 years ago

llopv commented 7 years ago

Subtitles can be added in the URL as a JSON:

https://ipfstube.erindachtler.me/v/QmYYMMKS5z9h2CL69GBTTys2SFRZH7XM2iiRTuqrYhYGkj?subs={"en":"Qmd9h2eZb4ft4cZAxtypj4YSs4iDu9kLfeXtG2ECgx4Mcc","es":"QmeVvJaydsTNJ493JPp5xcvMjMZaWBuS8eZoMCh6vpVTgV"}

This could be improved in the future, by allowing to open an IPFS file that links to the video and the subtitle files.

atfornes commented 7 years ago

Cool @llopv! nice feature!

Is this going to be merged? do you need a review?

download13 commented 7 years ago

Nah, I was just being lazy and never got around to it.