Closed mdietsche closed 7 years ago
Grids still do this too.
+1 Grant Kennedy
+1 Rory Wylie ticket 149888
+1 Carolyn Harris ticket 150265 not in Safari - confirmed in Chrome on my Mac, here: http://www.carolynlharris.com/2016/11/04/worlds-narrowest-street/
+1 Viktor Isaak ticket 159382 - voicing a complaint from his clients about the 1/2 or whole pixel sliver sometimes visible on bound galleries.
@benjamintennant @postmastersteve @danjonlam - next time you guys come across an instance of this can you let me know? This one is hard to reproduce, so it would help to see the issue in the wild.
@brianium I can send you something. I've seen it in some of our sites. Give me a little while and I scoop it out.
@lalunecreative awesome! Much appreciated brajjer.
So this isn't only effected by Safari, and or the method that Matt showed to reproduce, and when I've seen it it's been in some grid instances, and usually always sliders. For sliders though, that 1px is showing the previous/next image which happens to be dark. It's harder to see when it's not in this instance.
I think this is fixed in galleries. I'm going to close this issue and open a new one for the grid issue.
A gallery with something butted against the bottom will show a 1px line at the bottom at some display widths. To replicate, insert a gallery with a white background into a site that has entirely black backgrounds, open in Safari, and start resizing the window.
When calculating the width of each slide, and calculating the translation, we need to round up to a whole pixel or jankiness ensues.