search

downshiftorg / prophoto-issues

Public issue tracking for ProPhoto 6
8 stars 8 forks source link

Video backgrounds from YouTube or Vimeo do not fit the container #804

Open postmastersteve opened 6 years ago

postmastersteve commented 6 years ago

When users add a video background, the video is not positioned properly and does not scale to fit the block. Instead, they appear to scale to fit the browser height, even when the block is not the same height as the browser.

postmastersteve commented 6 years ago

+1 Jim Woolsey ticket 170425

jaredh159 commented 6 years ago

@postmastersteve I think you're documenting a known limitation here not a bug. If the user uses a third-party embed (YouTube or Vimeo) and they have it on a block that is not full height then we are not able to scale the video to fit the block correctly.

The solution is to either a) make the block full-height, or b) directly upload the video as an .mp4 which we can scale properly.

This shouldn't filed as a bug, as we wouldn't want users to think it was something we were going to get around to "fixing" -- because it's a technical limitation that we accepted when we built the feature, and we even mentioned it in the blog post.