Contact form selector displays all forms

[postmastersteve]

When a user is in their WordPress page editor and clicks "ProPhoto > Insert Form" they are presented with a popup which displays every form that has been created in the site.

Forms which appear in inactive designs are presented, as well as forms which were created in designs that have been deleted from ProPhoto are presented.

This selector should either:

• present only the forms in the design being customized, OR
• present forms from all designs the user has worked with but indicate in the dropdown whether the form comes from the current design or some other design.

Another idea is to keep forms as a global thing in ProPhoto, as this dropdown currently seems to do, but then represent every form in the "ProPhoto > Customizer > (toggle top-left switch to "Design") > Forms" area to match this reality. If we do this, we should reinforce the uniqueness of forms by requiring them to each have a unique name so you can tell them apart. In the screenshot above, 7 forms have the same name so I can't tell them apart.

[benjamintennant]

+1 simon dorn ticket 174538 - this took a while for us to resolve