downshiftorg / prophoto-issues

Public issue tracking for ProPhoto 6
8 stars 8 forks source link

Mobile menu background color is applied to the <body> #841

Open postmastersteve opened 6 years ago

postmastersteve commented 6 years ago

Mobile slide-out menu background color is assigned to the element, which is a mistake. This color should be applied to the nav#alt-nav element or nav.slideout-menu selector instead for the intended result.

On a related note, the Site Background Color should probably be assigned to the instead of the #inner-body element for the intended result.

The symptoms of this incorrect color assignment are that the mobile menu background color can be seen through the top and bottom of some browsers (like iOS Safari behind the address bar & action bar) as well as when you scroll "past" the end of the body on touch devices.

Manually applying the color with a rule like nav#alt-menu { background-color: #7529FF; } is confirmed to fix the issue, as seen in this before/after comparison clip:

http://screenshots.pro.photo/2018-02-14_11-17-43.mp4

postmastersteve commented 6 years ago

+1 Haylee Schiavo ticket 175770