downthecrop / betterdgg

Better Better Destiny.gg // Make Destiny.gg Great Again!
http://downthecrop.xyz/bbdgg
Other
2 stars 3 forks source link

The Future of Better Better Destiny.gg #89

Open downthecrop opened 7 years ago

downthecrop commented 7 years ago

I just had a talk with Cene about the future of the core site and what that's means for our extension.

We're not getting killed off but we have some work to do if we want this project to keep going.

With the code shift taking place on the site a lot of the things we plug into are now out of scope.

An example of what I'm talking about here. Here's a message I sent to Cene about the changes when I was first testing.

Hey just I'm not super familiar with JS classes. Am i still able to call these functions without imports? https://github.com/destinygg/website/blob/eacc9708eaf258dd897156354b2b97054307a38b/assets/chat/js/messages/user.js#L45 Compared to the old way which was https://github.com/destinygg/website/blob/970cbb7227e9582fb4a5303e31b39fc9dee48bf5/static/chat/js/gui.js#L1000 I was able to call the old ones like this https://github.com/BryceMatthes/betterdgg/blob/master/betterdgg/modules/flair.js#L105

Cene explained to me that they were now out of scope and inaccessible.

I think most of us have known about these changes coming for a while. SgtMaximum told me back in December and these changes have been up on the staging site since then https://stage.destiny.gg/

After talking with Cene on Discord he said the best way for us to move forward would likely be to branch the main site and serve most of chat to our users ourselves. This would involve a lot of rewriting on our end too.

Not sure what kind of a time frame we have for getting our stuff up to date but the fact that the extension doesn't work with the new site has definitely been putting a stall in their workflow.

Thanks for reading.

Comments or ideas?

04/30/2017 Edit: Got some advice on how we could achieve this from blushies on Discord

1.create new, forked+modified bundle

  1. redirect to that bundle https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/webRequest/onBeforeRequest This event is triggered when a request is about to be made, and before headers are available. This is a good place to listen if you want to cancel or redirect the request.

easy dude you're gonna have to rewrite shit its literally a 2 step process to get back in-scope it should be cleaner even because you're not having to work around every other feature

kenany commented 7 years ago

branch the main site and serve most of chat to our users ourselves

I'm a little confused. What does this mean? From some Discord chatting, it seems like this means serving a forked version of the site's JavaScript in order to expose the functions we need.

PinkishCow commented 7 years ago

DED EXTENSION

FeelsBadMan 😢