search

downthemall / anticontainer

DownThemAll! AntiContainer (Extension to a Firefox, Seamonkey extension)
Mozilla Public License 2.0
93 stars 41 forks source link

Added several plugins #112

Closed marianocarrazana closed 8 years ago

marianocarrazana commented 8 years ago

Included zippyshare, solidfiles, and anothers images hosts(simples and sandboxes['continue...' forms]).

poke commented 8 years ago

Can you please rebase this against our current master branch? Most of the commits that are included in this PR are redundant.

nmaier commented 8 years ago

You reuse the get() function a lot, always similar. I wonder if it would make sense to generalize it a bit and make it a helper function available to all plugins.

Your sandbox plugins should always call finish(), whether you called setURL or not.

Also what @poke said, rebase please

poke commented 8 years ago

The get function itself doesn’t actually seem necessary since there is no recursion involved (so you could just have the code execute outside of the function).

But yeah, I agree that there is definitely a pattern in these plugins. Maybe we could expand the redirector or resolver plugin type to support posting data, so we could avoid having sandbox plugins for every of these sites.

marianocarrazana commented 8 years ago

@poke @nmaier ok, i will clean it

poke commented 8 years ago

Note that you do not need close this pull request and open a new one; you can just rebase your work locally, and then force-push to your fork (git push --force) to overwrite the branch in your fork and update this pull request. So you could recycle it with adjusted changes :)