search

downthemall / anticontainer

DownThemAll! AntiContainer (Extension to a Firefox, Seamonkey extension)
Mozilla Public License 2.0
93 stars 41 forks source link

Request.send() with paramaters?! #55

Closed k7rim closed 8 years ago

k7rim commented 12 years ago

I was writing a plugin and with new request i needed to send request with method 'POST" (i needed this to submit form and the form uses method "POST")

anyway, according to this : https://developer.mozilla.org/en/XMLHttpRequest send can take optional parameter represent the body of the message (only in case of "POST")

I wrote the plugin and it didn't work ,so i checked the source code and i found this in XMLHttpRequest.prototype in sandboxfactories module line 99

the send function always sends null whatever parameters she get

and in sandboxscripts.js line 69 in Request.Prototype also the send function does't take parameters

so i changed that and it worked i was able to send the request and submit the form and the plugin worked successfully

so i wanted to point you guys to that issue so that it can be fixed

thank you for the great plugin.

nmaier commented 12 years ago

Since you already fixed it locally... Are you up to posting a pull request?