search

downthemall / downthemall-legacy

Official DownThemAll! repository. Pull requests welcome.
https://downthemall.org/
Other
516 stars 150 forks source link

Error message dialog boxes should be non-modal #125

Open obkb opened 8 years ago

obkb commented 8 years ago

DTA 3.0.8, Windows 7

Desired behavior: When a thread on an image board is removed (for example if it's been idle too long), then often all of the image files in that thread are also deleted from the server. If DTA is still downloading that thread, it's OK to notify me that the files are not available ("404 error"), but I should be able to delete all of the remaining image links.

Actual behavior: When a thread and all of its image files are removed, DTA starts putting up modal error message dialog boxes for each deleted file. This means I have to click the button on every dialog box in order to get rid of it. If the dialog boxes were non-modal, I would be able to access the main DTA window and delete the remaining links, then DTA would not try to download them, and there wouldn't be so many dialog boxes to click on.

Steps to reproduce:

  1. Go to an image board such as 4chan's /b/ (random).
  2. Find a thread with images and "add paused" all of them.
  3. Wait for the thread to be pruned or deleted.
  4. Start trying to download the images. Of course, every one will fail and each attempt will put up a dialog box that has to be clicked on.
nmaier commented 8 years ago
mainpane

This can be changed with that preference already, but having a separate preference for errors i would make sense.

obkb commented 8 years ago

Ah, I see. I had assumed that "When downloads are complete" meant "When files have been successfully downloaded", that is, without any errors.