downthemall / downthemall

The DownThemAll! WebExtension
https://downthemall.org/
Other
912 stars 104 forks source link

Resume fails after network errors #94

Open AVR2CO5 opened 4 years ago

AVR2CO5 commented 4 years ago

A 17Gb download from put.io failed partway through with a "network error". When I selected "resume", it started again from the beginning, but the .part file for the failed download still exists on my hard drive.

Resume worked correctly from put.io in the previous incarnation of DownThemAll.

OSX 10.11.6, Firefox 69.0

nmaier commented 4 years ago

The wonders of Firefox 😛 The downloads API we have to use is extremely bad at handling such things.

I'm guessing I'll have to fix this in Firefox itself.

nmaier commented 4 years ago

Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1580920

AVR2CO5 commented 4 years ago

The same thing happened again with the same file, although this time the reason for failure was given as "Internal browser error".

I didn't notice Firefox do anything unusual, it didn't crash or anything like that.

I'm now downloading directly using Save Link As.

nmaier commented 4 years ago

Yes, that's the Firefox internal downloader we have to use throwing errors. Regular "Save As" uses it too but you might get lucky still. Hope your download finishes.

BioSehnsucht commented 4 years ago

Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1580920

Apparently this got triaged as P5 (Won't fix but accepting patches for it) upstream ? Fixing it is beyond me, but thought I'd note that here for anyone who is hoping Firefox fixes it... :(

SteenG commented 3 years ago

At least Firefox can pickup from where it lost the download while DownThemAll begins all over (again and again).

ZaDarkSide commented 3 years ago

2021 still not solved on Chrome 😎

lee321987 commented 1 year ago

2022 still a problem.

spiralofhope commented 1 year ago

2023 still-- actually I don't know but I wanted to participate.

MiMoHo commented 1 year ago

Can confirm the problem exists in v4.8.1 with Firefox for Mac v110 in contrary to the Firefox in-built downloader that is able to resume failed individual token downloads after network issues. Issue got duplicated by #419 with a more comprehensive description. Please merge into here @nmaier

kiwichick888 commented 9 months ago

Still happening in v4.11.1 with Firefox 116.0.3.

HieronymusCH commented 1 week ago

And still happening. Now the *.part file even disappears after failing.

123.0 (64-Bit) Mozilla Firefox for Arch Linux archlinux - 1.0

kiwichick888 commented 1 week ago

And still happening. Now the *.part file even disappears after failing.

123.0 (64-Bit) Mozilla Firefox for Arch Linux archlinux - 1.0

I honestly don't think communications of any kind are being read. I've been trying for the last couple of years via email and forums but not a single reply or even acknowledgement of receipt. It galls me that the developer is still asking for donations to continue development but won't communicate with users.