doxxx / ffxiv-craft-opt-web

Web frontend for FFXIV Crafting Optimizer service.
zlib License
224 stars 200 forks source link

Solver misplacing Muscle Memory #395

Open Herosandwich opened 4 years ago

Herosandwich commented 4 years ago

Required Information

Class:ALC Level:80 Craftsmanship:2494 Control:2202 CP:459 Recipe Name: Grade 3 Tincture of Strength Recipe Level:80 Solver Seed: (Look at the top of the Execution Log on the Solver page) N/A, sporadic problem, plus I hit bug report and lost the seed b/c the page changed... now of course I can't get it to do it again... happened twice... nvm got one. put it in slot 6 Seed: 60150

Expected Behaviour

solver shouldn't put Muscle Memory anywhere but step 1 (Example: Standard Synthesis progress is 42)

Actual Behaviour

Solver will sporadically put muscle memory somewhere from step 3 to 5 (Example: Standard Synthesis progress is 38)

Steps To Reproduce

enter my info, hit solve a few times., had set to cunning craftsman's syrup HQ and blood bouillabaisse HQ (Example: Buffs, Food, Synthesis Condition, Simulator/Solver Options if different from default)

Herosandwich commented 4 years ago

forgot to add algorithm set to eaComplex

DatXFire commented 4 years ago

duplicate of #358

vlsergey commented 4 years ago

Tried to fix it in #396

gr3ger commented 4 years ago

I got the same problem today using the beta site. Started Solve session with no initial moves. Algorithm: eaSimple Population: 500 Generations: 300

Other than that I think I'm using the standard settings.

/ac "Reflect" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Prudent Touch" <wait.3>
/ac "Prudent Touch" <wait.3>
/ac "Master's Mend" <wait.3>
/ac "Manipulation" <wait.2>
/ac "Patient Touch" <wait.3>
/ac "Patient Touch" <wait.3>
/ac "Hasty Touch" <wait.3>
/ac "Innovation" <wait.2>
/ac "Patient Touch" <wait.3>
/ac "Great Strides" <wait.2>
/ac "Muscle Memory" <wait.3>
/ac "Byregot's Blessing" <wait.3>
/ac "Groundwork" <wait.3>

And here's another time it happened:

Algorithm: eaComplex Population: 1000 Generations: 300 image

gr3ger commented 4 years ago

I think the reason this is happening is because the solver thinks it will still get the buff but not the initial progress from using the action.

image image

gr3ger commented 4 years ago

Made a small pull request that seems to solve this issue. Tried several times in the simulator and it seems to be applying the buff correctly now.

399