doxxx / ffxiv-craft-opt-web

Web frontend for FFXIV Crafting Optimizer service.
zlib License
224 stars 200 forks source link

Groundwork still calculated to do half efficiency when under Waste Not I/II with less than 20 durability left #410

Open Drakonas opened 4 years ago

Drakonas commented 4 years ago

Required Information

Class: LTW (Applies to all) Level: 80 (N/A) Craftsmanship: 2603 (N/A) Control: 2639 (N/A) CP:528 (N/A) Recipe Name: Sea Swallow Leather (Applies to all) Recipe Level: 78 (Applies to all) Solver Seed: 192502. I created my own macro using the simulator, and the issue can be shown there.

Expected Behaviour

Using Groundwork under Waste Not II/I while in-game, when at 10 durability or higher, will still count the full 300% progress efficiency.

I can use this macro successfully. I can prove a 150% efficiency only goes to 1111/1822, if you replace the Groundwork with a Careful Synthesis. Groundwork, however, counts the full 300% with Waste Not II, and finishes the craft with the full 1822 progress.

Actual Behaviour

The solver/simulator thinks Groundwork still needs 20 durability to hit the 300% efficiency, even though the simulator solver does show that it only uses 10 durability during the craft. The progress is shown to only meet 1111/1822 progress in the solver.

Steps To Reproduce

Nothing different from default. Just these stats. No food or buffs. I created a rotation myself, and the issue is prevalent. I am not sure if this is being used in calculations for creating macros, but it very well might be and it would DEFINITELY negatively affect craft success with the solver.

dten commented 4 years ago

i fixed this in #406 but it's waiting to be merged

Drakonas commented 4 years ago

My apologies. Thanks for the headsup.