search

doxygen / doxygen

Official doxygen git repository
https://www.doxygen.org
GNU General Public License v2.0
5.67k stars 1.27k forks source link

Remove unnecessary null pointer checks #7198

Closed elfring closed 3 years ago

elfring commented 5 years ago

An extra null pointer check is not needed in functions like the following.

albert-github commented 3 years ago

The construct in getDefs does not exist anymore. The files Token.cc and VhdlParserTokenManager.h are generated files by means of JavaCC (doxygen has no influence on it).

I think the problem has been solved in the mean time.

elfring commented 3 years ago

Were any update candidates left over?

albert-github commented 3 years ago

The fileVhdlParser.h contains generated files by means of JavaCC (doxygen has no influence on it).

elfring commented 3 years ago

Would you like to achieve any improvements for source code which will be generated (by JavaCC)?

albert-github commented 3 years ago

Improvements are always welcome, but in this case this has to be done in the external JavaCC, the current javaCC version is 7.0.10 (see: https://javacc.github.io/javacc/) we use a bit older version as we have regularly problems with newer versions. I know that they are working om a version 8 (see e.g. https://github.com/javacc). From some discussions I got that javaCC is also more geared to Java generation than to C++ generation.