doy / package-stash-xs

faster and more correct implementation of the Package::Stash API
4 stars 3 forks source link

document rejecting unicode and binary names #5

Open rurban opened 9 years ago

rurban commented 9 years ago

Package::Stash has a wrong understanding of the Perl API, it uses a crazy regex filter to disallow certain package names. perl5.16 allows the full set of binary characters as package name, even embedded \0 (it is now officially "binary (un)safe"), and it also allows unicode names.

This needs to be documented that it is ASCII only.

But I would rather call this drastic limitation a bug, and the regex filter should be rather left out, and I would provide a Package::Stash::ASCII module with this filter enabled.

Not talking about the wrong setting of the utf8 flag on the names. This is a seperate ticket already.

ribasushi commented 9 years ago

See also 1st paragraph of https://github.com/karenetheridge/Sub-Name/pull/4#issuecomment-87768003 and https://github.com/karenetheridge/Sub-Name/pull/4#issuecomment-87824645