search

doy / rbw

unofficial bitwarden cli
https://git.tozt.net/rbw
Other
573 stars 82 forks source link

fix rbw-pinentry-keyring not saving passwords correctly and not working with 2fa codes and add auto setup #178

Closed HenkVanMaanen closed 2 weeks ago

HenkVanMaanen commented 1 month ago

This PR solves 3 things:

  1. the rbw-pinentry-keyring setup command did not support passwords that includes a space. The cut command only retrieved the first word of the password and thus skipping the other words. cut -c3- cuts from the 3rd char 'D ' to the end of the line.

So pinentry output like D this is a passphrase will be cut to this is a passphrase.

Can be tested with the following commands:

old: echo "D this is a passphrase" | cut -d' ' -f2 new: echo "D this is a passphrase" | cut -c3-

2. Also the script doesnt work with 2fa codes because the secret-tool is called for the 2fa code instead of the system pinentry. This PR also fixes that bug.

3. This PR also removes the setup command and it will auto setup if the password is not found in the keyring. Also there is a new command added: clear, with this command the password can be cleared from the keyring in case it needs to be updated or removed.

doy commented 2 weeks ago

thanks!