Closed fdw closed 2 months ago
Hey @doy, are you still interested in this PR?
This PR is now about two years old, with no reaction from you, @doy. If you are interested in it, please tell me, otherwise I'll close the PR.
sorry about that - i had assumed that it being in draft meant you were still working on it. honestly, i'd rather see this sort of functionality covered by the json output rather than include it in the default output, because it's not usually that relevant - is there something specific you're interested in here?
Including it in the JSON output would be fine for me too - I think this PR draft predates JSON 😉
However, it's not there yet, is it? Should I try to open a PR? (But be warned that I'd need some help.)
i added this to the json output in 0942dde - if this works for you, i'd prefer this implementation, but let me know if there's some other functionality you'd like here.
I think my needs are already satisfied with https://github.com/doy/rbw/commit/869d36481c398ad65595e01b32714720dd6cfb1e#diff-7d7d3a6ce5c2a3e8b39ce4f49b78a71365c8e06c0d9ddb78bc2dca68bfeb4a5bR150 in 1.10.0 but i could not test it yet. It looks good from looking at the code. Big thanks to all involved!
Yes, looks good to me. Thank you!
This adds some code to get the type of a custom field and to display it. However, some fine-tuning is probably necessary...
Issue: #67