search

doy / runes

a modern terminal client
Other
35 stars 1 forks source link

verify pty handling #7

Open doy opened 10 years ago

doy commented 10 years ago

I didn't put a whole lot of effort into making sure that the pty handling code is correct. It seems to work fine, but I haven't done any serious tests of things like job control yet.

doy commented 10 years ago

In particular, I should most likely be clearing the environment before spawning the new process.

doy commented 10 years ago

Nope, clearing the environment isn't right, but setting $TERM is, which I have just done. Still need to look into the other stuff.

dolmen commented 10 years ago

$COLORTERM must also be cleaned because it is set by gnome-terminal. Check this: http://vim.wikia.com/wiki/256_colors_in_vim

doy commented 10 years ago

Good call, thanks.