search

doy / spreadsheet-parsexlsx

parse XLSX files
http://metacpan.org/release/Spreadsheet-ParseXLSX
27 stars 35 forks source link

Add TabColor and ColFmtNo support to ParseXLSX #26

Closed felliott closed 10 years ago

felliott commented 10 years ago

Hello,

This patch adds two new features to ParseXLSX to make it compatible with ParseExcel. The first commit adds support for getting the tab color of the current worksheet. The second sets the undocumented ColFmtNo property of Spreadsheet::ParseExcel::Worksheet (see https://metacpan.org/source/DOUGW/Spreadsheet-ParseExcel-0.65/lib/Spreadsheet/ParseExcel.pm#L1367), which stores the column default formats. I have added tests for both features. Please let me know if there is anything you'd like me to fix or change. Thank you and have a great day!

Cheers, Fitz

doy commented 10 years ago

Can you provide an example spreadsheet which demonstrates these features, so I can add it to the test suite?

felliott commented 10 years ago

On Jul 4, 2014, at 8:32 PM, Jesse Luehrs notifications@github.com wrote:

Can you provide an example spreadsheet which demonstrates these features, so I can add it to the test suite?

Hey Jesse,

I’ve added them to t/data/Test.xlsx already. Should I revert that and put them in a separate spreadsheet?

Cheers, Fitz

doy commented 10 years ago

Oh, I missed that. Yeah, if you could put that in a separate spreadsheet, that would be helpful - it's easier to keep track of that way, since Excel files don't diff well.

felliott commented 10 years ago

I've split out the features into two new test files and rebased the commits on top of v0.15. Please let me know if I need to fix anything else. Thanks and have a great weekend!

Cheers, Fitz

doy commented 10 years ago

Thanks!