search

doy / spreadsheet-parsexlsx

parse XLSX files
http://metacpan.org/release/Spreadsheet-ParseXLSX
27 stars 35 forks source link

Add rudimentary support for hyperlinks in cells #63

Open gquipster opened 8 years ago

gquipster commented 8 years ago

This is rough and ready but works for me with the file I have.

I don't currently have time to add a test but will try to do so in the next few weeks.

doy commented 8 years ago

Let me know when you have a test for this - I'd rather not add new features that I'm not familiar with without tests (so that I don't accidentally break them in the future).

gquipster commented 8 years ago

Hi,

Tweaked the code to make it slightly less rudimentary (so it now handles internal links as well as external) and to work with the same set of tests as Spreadsheet::ParseExcel.

I've marked some of the tests as TODO as I get back different values to Spreadsheet::ParseExcel - to my mind the values returned by this module are correct as they are what is in the spreadsheet, but it does differ to what Spreadsheet::ParseExcel was expecting, so I've left them expecting the values Spreadsheet::ParseExcel was for now rather than changing to what this module actually returns.

Thanks

warnes commented 3 years ago

Per #97, please create a PR at https://github.com/r-gregmisc/spreadsheet-parsexlsx.