search

doy / spreadsheet-parsexlsx

parse XLSX files
http://metacpan.org/release/Spreadsheet-ParseXLSX
27 stars 35 forks source link

Unini warning from $version->att('appName') #66

Open andk opened 8 years ago

andk commented 8 years ago

Tiny nit: I got two spreadsheets recently that had an undefined warning coming from $version->att('appName').

My personal workaround was this patch:

--- Spreadsheet/ParseXLSX.pm~       2016-08-16 09:10:03.000000000 +0200
+++ Spreadsheet/ParseXLSX.pm        2016-08-30 09:21:28.253374212 +0200
@@ -103,7 +103,7 @@
     my ($properties) = $files->{workbook}->find_nodes('//s:workbookPr');

     if ($version) {
-        $workbook->{Version} = $version->att('appName')
+        $workbook->{Version} = $version->att('appName')||'noAppName'
                              . ($version->att('lowestEdited')
                                  ? ('-' . $version->att('lowestEdited'))
                                  : (""));
maiku41 commented 7 years ago

We're seeing the same thing.