doy / spreadsheet-parsexlsx

parse XLSX files
http://metacpan.org/release/Spreadsheet-ParseXLSX
27 stars 35 forks source link

Undeclared dependency on Archive::Tar 1.34(?) #83

Open cpansprout opened 6 years ago

cpansprout commented 6 years ago

With Archive::Tar 1.30 I get test failures:

t/basic.t .................. 1/? error: file not seekable 
 at /System/Library/Perl/Extras/5.12/Archive/Zip/Archive.pm line 576
    Archive::Zip::Archive::readFromFileHandle('Archive::Zip::Archive=HASH(0x7f9f22dfbf30)', 'GLOB(0x7f9f22dd6288)') called at /Users/sprout/.cpan/build/Spreadsheet-ParseXLSX-0.27-18OXW7/blib/lib/Spreadsheet/ParseXLSX.pm line 58
    Spreadsheet::ParseXLSX::parse('Spreadsheet::ParseXLSX=HASH(0x7f9f22b539c8)', 'SCALAR(0x7f9f22d8ff28)') called at t/basic.t line 17
Can't open scalar ref as a zip file at /Users/sprout/.cpan/build/Spreadsheet-ParseXLSX-0.27-18OXW7/blib/lib/Spreadsheet/ParseXLSX.pm line 58.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 2 just after 456.
t/basic.t .................. Dubious, test returned 2 (wstat 512, 0x200)
All 456 subtests passed 

I see this in Archive::Tar’s change log:

1.34 Mon 2 Dec 2013
    - Restore svn history from svn.ali.as (thanks H. Merijn Brand)
    - #90854 Test 17 in t/03_ex.t is failing
    - Allow reading ZIP from seekable streams (like PerlIO::Scalar)
    - RT#75197
    - Fixes: #76780: Cannot create member called "0" with addString (HAGGAI)

I assume ‘Allow reading ZIP’ has something to do with it. It works when I upgrade to Archive::Tar 1.60.