search

doy / spreadsheet-parsexlsx

parse XLSX files
http://metacpan.org/release/Spreadsheet-ParseXLSX
27 stars 35 forks source link

Require minimum version of Archive::Zip #89

Closed nrdvana closed 6 months ago

nrdvana commented 5 years ago

Spreadsheet::ParseXLSX has a test case that opens a scalar ref as a file. Archive::Zip earlier than 1.34 can't support this, and fails the test.

error: file not seekable 
 at /usr/lib/perl5/vendor_perl/5.12.3/Archive/Zip/Archive.pm line 576.
        Archive::Zip::Archive::readFromFileHandle(Archive::Zip::Archive=HASH(0x8e3ca60), GLOB(0x8d2e368)) called at /home/mconrad/.cpanm/work/1546451049.12404/Spreadsheet-ParseXLSX-0.27/blib/lib/Spreadsheet/ParseXLSX.pm line 58
        Spreadsheet::ParseXLSX::parse(Spreadsheet::ParseXLSX=HASH(0x8d1fed0), SCALAR(0x8c85d08)) called at t/basic.t line 17
Can't open scalar ref as a zip file at /home/mconrad/.cpanm/work/1546451049.12404/Spreadsheet-ParseXLSX-0.27/blib/lib/Spreadsheet/ParseXLSX.pm line 58.
warnes commented 3 years ago

Per #97, please create a PR at https://github.com/r-gregmisc/spreadsheet-parsexlsx.