search

doy / text-handlebars

http://handlebarsjs.com/ for Text::Xslate
http://metacpan.org/release/Text-Handlebars
6 stars 9 forks source link

fixes #each block helper for iterating over hashrefs #10

Open theraccoonbear opened 7 years ago

theraccoonbear commented 7 years ago

Fixes #9 based on patch from @rmesser

theraccoonbear commented 7 years ago

Apologies. I'm not familiar with the Travis CI failure. It appears to be Perl version related. If this is an issue with my code I'm happy to correct things, I'm just not sure what's wrong.

rmesser commented 7 years ago

The failures are only for Perl 5.10 and 5.12, and the error is with Dist::Zilla, so apparently not related to the patch. Presumably this test would also fail without the patch. See this line in the logs:

Configuring Dist-Zilla-6.008 Running Makefile.PL Perl v5.14.0 required--this is only v5.12.5, stopped at Makefile.PL line 5.

I'm not sure of the resolution or the relative importance of supporting Perl 5.12 and before.

theraccoonbear commented 7 years ago

For me personally, it is not an issue. Either way, I hope this patch is accepted, it's a pretty major need for Handlebars functionality to avoid some of the awkward data reindexing/restructuring that lesser systems like Mustache require.

theraccoonbear commented 7 years ago

Realized this was probably something in the .travis.yml. So now Perl 5.10 and 5.12 are not tested, due to, apparently Dist::Zilla's requirements. I am not well versed in Travis CI lingo, so if there's a way to go back to an older, supported version of Dist::Zilla I am not sure how to do it. Would love to see this patch get merged in so I can rely on it everywhere.

amit777 commented 7 years ago

Hiya! thanks for making this module. I was wondering if this pull request is planned to be merged?