doyourownswing / doyourownswing.github.io

DoYourOwnSwing website
2 stars 0 forks source link

Updates NavBarOption to allow passing a custom isCurrentPage function #6

Closed jesseez closed 3 months ago

jesseez commented 3 months ago

When the url had no hash, there was no nav bar highlight. Now it does highlight if there is no hash, there is an empty hash, etc.

Kuboosh21 commented 3 months ago

The routing breaks if you manually add the different directories to the url - it won't navigate to the correct page. Once you click on the nav tab, it won't undo any manual changes

image

jesseez commented 3 months ago

The routing breaks if you manually add the different directories to the url - it won't navigate to the correct page. Once you click on the nav tab, it won't undo any manual changes

image

We use the HashRouter since that's what github pages supports. It only looks at anything behind #/ .I think we can operate under the assumption that users won't manually change the URL. If the page breaks, that's their own fault